solidus icon indicating copy to clipboard operation
solidus copied to clipboard

Clear order promotions in Omnes event

Open mamhoff opened this issue 1 year ago • 1 comments

Summary

This moves clearing the connected order promotions upon emptying an order into an Omnes::Subscriber. This saves us from having to override Spree::Order#empty! in the solidus_legacy_promotions gem.

Checklist

The following are mandatory for all PRs:

mamhoff avatar May 16 '24 15:05 mamhoff

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 88.88%. Comparing base (098260d) to head (914d1aa).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5754   +/-   ##
=======================================
  Coverage   88.87%   88.88%           
=======================================
  Files         708      709    +1     
  Lines       16825    16835   +10     
=======================================
+ Hits        14953    14963   +10     
  Misses       1872     1872           

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar May 16 '24 15:05 codecov[bot]