solidus icon indicating copy to clipboard operation
solidus copied to clipboard

[Admin][UI][Bulk actions] Require confirmation before completing bulk deletes

Open forkata opened this issue 1 year ago • 2 comments

Currently, bulk deleting resources such as products happens without confirmation. This is not ideal, so we want to introduce a manual confirmation step.

There's no specific design for this, but we can reference what we have for deleting a product with a different copy such as

Remove 3 products?
This can't be undone.

Image

forkata avatar May 02 '24 18:05 forkata

The first part of this is done, which is adding the ability to confirm a batch action. I think we may want this to be the default behaviour for all batch actions?

The second part is implementing the modal instead of the default browser confirm dialog.

forkata avatar May 02 '24 18:05 forkata

First part of this change was merged here https://github.com/solidusio/solidus/pull/5702

forkata avatar May 02 '24 20:05 forkata

The second part of this work (converting the window.confirm() alert to a custom styled modal) was started in this PR but was cancelled and closed after it became clear that it would be a decent amount of work to redesign this flow (unlike the window.confirm() method, modals don't block JS execution while they wait for user input, and disrupting the form submission with e.preventDefault to await a promise also had its complicating factors).

Since we have other larger admin features that still require work, for now we are closing this issue. In the future, if we have extra time on our hands to spend on purely visual changes rather than functional ones, we can revisit this issue, but for now we will focus on the large outstanding backlog of admin features!

MadelineCollier avatar Aug 13 '24 12:08 MadelineCollier