solidus icon indicating copy to clipboard operation
solidus copied to clipboard

Add extension point: Promotion finder

Open mamhoff opened this issue 2 years ago • 1 comments

Summary

The API gem references the promotion system in very few places, namely in the promotions endpoint. This endpoint is only accessible to admins, and our admin doesn't actually check it, so another option would be to remove the endpoint entirely.

However, it's simple enough to create a class that does what we need here.

Checklist

Check out our PR guidelines for more details.

The following are mandatory for all PRs:

The following are not always needed:

  • 📖 I have updated the README to account for my changes.
  • 📑 I have documented new code with YARD.
  • 🛣️ I have opened a PR to update the guides.
  • ✅ I have added automated tests to cover my changes.
  • 📸 I have attached screenshots to demo visual changes.

mamhoff avatar Mar 02 '24 11:03 mamhoff

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 88.87%. Comparing base (49e3da4) to head (2f29de0).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5677      +/-   ##
==========================================
+ Coverage   88.86%   88.87%   +0.01%     
==========================================
  Files         695      697       +2     
  Lines       16589    16599      +10     
==========================================
+ Hits        14741    14752      +11     
+ Misses       1848     1847       -1     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Mar 02 '24 11:03 codecov[bot]