solidus icon indicating copy to clipboard operation
solidus copied to clipboard

Published 20 hours ago • verified publisher icon solidusio

Keep backorders when splitting part of variant to new shipment with same SL

Open spaghetticode opened this issue 11 months ago • 2 comments

Summary

Fixes #5669

When splitting a shipment to the same stock location, when not the whole quantity for the variant is moved it may happen, if there are backordered items, that these disappear (they become on hand).

This PR first reworks and adds further coverage to specs for the Spree::FulfilmentChanger service to expose the issue, then addresses it in the last commit.

https://github.com/solidusio/solidus/assets/141220/eea2c906-6a8d-44b4-83cd-8b7207b0b78a

Checklist

Check out our PR guidelines for more details.

The following are mandatory for all PRs:

  • [x] I have written a thorough PR description.
  • [x] I have kept my commits small and atomic.
  • [x] [I have used clear, explanatory commit messages]
  • [x] I have added automated tests to cover my changes.

spaghetticode avatar Feb 26 '24 14:02 spaghetticode

Hey @spaghetticode, is this still a draft intentionally or can we start reviewing?

kennyadsl avatar Feb 27 '24 10:02 kennyadsl

@kennyadsl it should be good for review, I'm sorry for the confusion.

spaghetticode avatar Feb 27 '24 10:02 spaghetticode