solidus_social icon indicating copy to clipboard operation
solidus_social copied to clipboard

Merge guest user cart with authenticated one

Open VitaliyAdamkov opened this issue 5 years ago • 3 comments

https://github.com/solidusio-contrib/solidus_social/issues/80

VitaliyAdamkov avatar Jul 08 '20 10:07 VitaliyAdamkov

@VitaliyAdamkov thanks! How about also adding a few tests for this? You can probably take inspiration from the tests in solidus_auth_devise.

aldesantis avatar Jul 08 '20 12:07 aldesantis

oh, sure, i'll try to do my best)

ср, 8 лип. 2020 о 15:04 Alessandro Desantis [email protected] пише:

@VitaliyAdamkov https://github.com/VitaliyAdamkov thanks! How about also adding a few tests for this? You can probably take inspiration from the tests in solidus_auth_devise https://github.com/solidusio/solidus_auth_devise/blob/master/spec/controllers/spree/user_sessions_controller_spec.rb#L30 .

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/solidusio-contrib/solidus_social/pull/81#issuecomment-655476679, or unsubscribe https://github.com/notifications/unsubscribe-auth/AGBCDJ52QT62JMCNWTC6UOLR2ROF7ANCNFSM4OUOJBNQ .

VitaliyAdamkov avatar Jul 08 '20 12:07 VitaliyAdamkov

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Sep 06 '20 13:09 stale[bot]

@kennyadsl do you think this is still an issue?

fthobe avatar Jan 08 '25 10:01 fthobe

VitaliyAdamkov

Hey, do you think you can add a test and rebase, we would like to merge this :)

fthobe avatar Jan 28 '25 11:01 fthobe

@jarednorman can be closed, superseeded by #129

fthobe avatar Jan 29 '25 15:01 fthobe