solid icon indicating copy to clipboard operation
solid copied to clipboard

feat: createMutable support for class inheritance

Open ddomonkos opened this issue 11 months ago • 1 comments

Summary

When using createMutable on a class which extends another class, reading from a getter of the parent class does not signal the subscribers. This is because for classes only the properties of the object's immediate prototype were being handled, not the entire (potential) chain of prototypes.

How did you test this change?

Added a test and I tested it in my app where I've stumbled upon the issue where I could confirm that it works.

ddomonkos avatar Jan 15 '25 22:01 ddomonkos

🦋 Changeset detected

Latest commit: a07b27d9d1f91bd55e4405a3eaa28930be91c498

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
solid-js Patch
test-integration Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

changeset-bot[bot] avatar Jan 15 '25 22:01 changeset-bot[bot]