dev: Use `devComponent` in `lazy`
Because lazy doesn't call the component function using JSX or createComponent it doesn't show up in the devtools properly.
This replaces the function call with devComponent if in dev mode.
Although it may be a bit odd, as devComponent is an internal-only api, and lazy should probably be fully implementable in userland, right?
Maybe there is a way to just use createComponent there, as the logic is very similar.
return createMemo(() => (Comp = comp()) ? createComponent(Comp, props) : "")
⚠️ No Changeset found
Latest commit: 8492549f1756cf22dba53b4376e255355a397506
Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.
This PR includes no changesets
When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types
Click here to learn what changesets are, and how to add one.
Click here if you're a maintainer who wants to add a changeset to this PR
Pull Request Test Coverage Report for Build 12521432658
Details
- 3 of 3 (100.0%) changed or added relevant lines in 1 file are covered.
- 1 unchanged line in 1 file lost coverage.
- Overall coverage increased (+1.3%) to 86.957%
| Files with Coverage Reduction | New Missed Lines | % |
|---|---|---|
| packages/solid/src/reactive/scheduler.ts | 1 | 80.95% |
| <!-- | Total: | 1 |
| Totals | |
|---|---|
| Change from base Build 11846786421: | 1.3% |
| Covered Lines: | 2332 |
| Relevant Lines: | 2612 |
💛 - Coveralls
My only concern with this is does this impact hydration.. like component counting mismatch. I haven't been able to verify but when we choose to create component vs not is usually very intentional for matching hydration IDs.