solid icon indicating copy to clipboard operation
solid copied to clipboard

make a named export for solid-js/html for autocompletion in IDEs

Open trusktr opened this issue 1 year ago • 3 comments

Summary

Clearly-named exports appear as autocomplete results in IDEs like VS Code. This allows someone to, for example, write the following JS code with | representing the cursor location:

function Comp() {
  return html|
}

and IDEs that use TypeScript Language Server (f.e. VS Code) will propose to automatically add import {html} from 'solid-js/html', converting the code to the following when the user hits the Tab key (default in most IDEs) to accept the auto-completion:

import {html} from 'solid-js/html'

function Comp() {
  return html|
}

trusktr avatar Sep 01 '24 16:09 trusktr

🦋 Changeset detected

Latest commit: 467e872da7d2be532e05f21dd01c2e72484ff2a2

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
solid-js Patch
test-integration Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

changeset-bot[bot] avatar Sep 01 '24 16:09 changeset-bot[bot]

Pull Request Test Coverage Report for Build 10655705996

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 93.342%

Totals Coverage Status
Change from base Build 10586064173: 0.0%
Covered Lines: 4196
Relevant Lines: 4429

💛 - Coveralls

coveralls avatar Sep 01 '24 16:09 coveralls

Actually I just tested, and autocompletion will work as long as the app already imports the default html somewhere first. So this change is not needed for that.

This does make it easy to write things like export * from 'solid-js/html' though, so I'd say keep it.

trusktr avatar Sep 01 '24 19:09 trusktr