solid icon indicating copy to clipboard operation
solid copied to clipboard

Universal Renderer's cleanup method doesn't remove existing node

Open nyanrus opened this issue 7 months ago • 5 comments

Describe the bug

Universal Renderer's cleanup method (the return value of render function) doesn't remove the existing node, which is inconvenient for using HMR.

Your Example Website or App

https://stackblitz.com/edit/solidjs-templates-ycgqgq?file=src%2Findex.tsx

Steps to Reproduce the Bug or Issue

  1. See the rendered result.

Expected behavior

I ran the cleanup method and I expected the node to be removed.

Screenshots or Videos

image

Platform

  • OS: Windows 11
  • Browser: Firefox
  • Version: 115

Additional context

I am using solid-js for Firefox XUL, non-standard HTML, for developing a custom browser. While I making HMR using Vite, I encountered the problem. Thank you for the good project!

nyanrus avatar Jun 30 '24 14:06 nyanrus