solid-start icon indicating copy to clipboard operation
solid-start copied to clipboard

Remove hardcoded `node_modules`

Open rtritto opened this issue 3 years ago • 1 comments

Not all package managers use node_modules as target folder to save modules. An example is yarn Berry, with Plug'n'Play enabled (pnp loader), that use ./yarn/cache or global cache folder instead of node_modules one.

All absolute imports to relative imports: Example for packages/start/vite/index.d.ts:

- import { Plugin } from "node_modules/vite";
+ import { Plugin } from "vite";

rtritto avatar Dec 03 '22 17:12 rtritto

Yeah this is super strange. Maybe it was an auto code import? @nksaraf

ryansolid avatar Dec 03 '22 17:12 ryansolid

@ryansolid @nksaraf node_modules come back.

rtritto avatar Feb 04 '23 01:02 rtritto

@ryansolid @nksaraf can this issue be reopened?

rtritto avatar Feb 16 '23 00:02 rtritto