solid-start icon indicating copy to clipboard operation
solid-start copied to clipboard

Build succeeds despite transformations failed

Open pawelblaszczyk5 opened this issue 2 years ago • 0 comments

It looks like the build is succeeding even if Solid Start specific transformations using esbuild fails. I would expect it to exit with non-0 code so it would properly fail e.g. GitHub actions.

Reproduction: https://stackblitz.com/edit/vitejs-vite-mktcwb?file=package.json

Steps:

  • Go to reproduction
  • Run npm run build
  • Build succeeds despite errors and broken output

Note: I know what's the solution to the fail in reproduction (usage of unsupported by Solid Start's esbuild version TypeScript syntax) 😛

pawelblaszczyk5 avatar Nov 30 '22 15:11 pawelblaszczyk5