solid-start icon indicating copy to clipboard operation
solid-start copied to clipboard

[solid-start-static]: assets are linked from `/` instead of using `config.base`

Open atk opened this issue 3 years ago • 1 comments

Reproduction:

Use the default solid-start starter with the static adapter and in vite.config.ts, you set base: "" or base: "./". Run npm run build (or pnpm or yarn).

Expected outcome:

In index.html, assets are linked from a relative path, according to the given base.

Actual outcome:

in both cases, the base path is ignored and the assets are still linked from /assets/....

Workaround:

Use sed to fix the path, e.g. sed -i 's/\\/assets/assets/g' dist/index.html, but that's not an ideal workflow.

atk avatar Oct 13 '22 10:10 atk

Fixed in PR #311

atk avatar Oct 13 '22 19:10 atk