solid-start icon indicating copy to clipboard operation
solid-start copied to clipboard

[Bug?]: SSR adds commas between children (in meta title)

Open drdxk opened this issue 4 months ago • 3 comments

Duplicates

  • [x] I have searched the existing issues

Latest version

  • [x] I have tested the latest version

Current behavior 😯

SSR renders children with a comma between each node.

Image

CSR fixes the render with the first update:

Image

Expected behavior 🤔

No commas separating children of <Title> from server's initial render

Steps to reproduce 🕹

Steps:

  1. Most basic repro is https://github.com/drdxk/tmp-solid-start-ssr-meta/tree/main
  2. Which is obtained via: npm init solid@latest, typescript, basic template
  3. Sole commit: https://github.com/drdxk/tmp-solid-start-ssr-meta/commit/600b1a20ebda88db73689b89df06ac12558e7ae5
  • This adds a CustomTitle component as described in this doc
  1. Behavior is observed both with run and build+start

Context 🔦

No response

Your environment 🌎


drdxk avatar Aug 04 '25 18:08 drdxk

Since this is an issue with the solid-meta module, it will be handled by solid-meta #63.

dennev avatar Aug 05 '25 06:08 dennev

duplicate of https://github.com/solidjs/solid-meta/issues/45 and it seems its already fixed?

huseeiin avatar Aug 05 '25 19:08 huseeiin

As I mentioned in the PR, this can only solve one-dimensional arrays, and unlike client-side processing, which solves all nested arrays, it cannot currently solve arrays of two or more dimensions, such as the issue.

I ran the issue example with the code before and after the commit, and the output results after the modification are the same on the user screen (view).

dennev avatar Aug 06 '25 00:08 dennev