[Bug?]: Dev server crashes when `onCleanup` callback throws in SSR

[yume-chan]

Duplicates

• [x] I have searched the existing issues

Latest version

• [x] I have tested the latest version

Current behavior 😯

I was testing https://github.com/Azq2/js-lingui-solid/issues/1, but If the onCleanup callback throws any error, the whole dev server will crash:

For example, if I add:

export default function App() {
    onCleanup(() => { throw new Error("") })

    // ,,,
}

pnpm dev log:

> pnpm dev

> example-basic@ dev C:\dev\yume-chan\dev-server-crash
> vinxi dev

vinxi v0.5.3
vinxi starting dev server

  ➜ Local:    http://localhost:3000/
  ➜ Network:  use --host to expose

C:/dev/yume-chan/dev-server-crash/src/app.tsx:14
    throw new Error("");
    ^

Error
    at Array.eval (C:/dev/yume-chan/dev-server-crash/src/app.tsx:14:11)
    at cleanNode (file:///C:/dev/yume-chan/dev-server-crash/node_modules/.pnpm/[email protected]/node_modules/solid-js/dist/server.js:140:68)
    at cleanNode (file:///C:/dev/yume-chan/dev-server-crash/node_modules/.pnpm/[email protected]/node_modules/solid-js/dist/server.js:136:49)
    at cleanNode (file:///C:/dev/yume-chan/dev-server-crash/node_modules/.pnpm/[email protected]/node_modules/solid-js/dist/server.js:136:49)
    at cleanNode (file:///C:/dev/yume-chan/dev-server-crash/node_modules/.pnpm/[email protected]/node_modules/solid-js/dist/server.js:136:49)
    at file:///C:/dev/yume-chan/dev-server-crash/node_modules/.pnpm/[email protected]/node_modules/solid-js/dist/server.js:58:52
    at Timeout._onTimeout (file:///C:/dev/yume-chan/dev-server-crash/node_modules/.pnpm/[email protected]/node_modules/solid-js/web/dist/server.js:790:13)
    at listOnTimeout (node:internal/timers:594:17)
    at process.processTimers (node:internal/timers:529:7)

Node.js v22.14.0
 ELIFECYCLE  Command failed with exit code 1.

Expected behavior 🤔

The dev server logs the error but doesn't crash.

Steps to reproduce 🕹

Steps:

1. Clone https://github.com/yume-chan/solid-start-dev-server-crash
2. pnpm i and pnpm dev
3. Open http://locahost:3000 in browser
4. See dev server crash

Context 🔦

No response

Your environment 🌎

System:
    OS: Windows 11 10.0.26100
    CPU: (16) x64 AMD Ryzen 7 8845HS w/ Radeon 780M Graphics     
    Memory: 4.95 GB / 31.29 GB
  Binaries:
    Node: 22.14.0 - C:\Program Files\nodejs\node.EXE
    npm: 10.9.2 - C:\Program Files\nodejs\npm.CMD
    pnpm: 10.6.5 - ~\AppData\Local\pnpm\pnpm.CMD
  npmPackages:
    @solidjs/meta: ^0.29.4 => 0.29.4 
    @solidjs/router: ^0.15.0 => 0.15.3 
    @solidjs/start: ^1.1.0 => 1.1.3 
    solid-js: ^1.9.5 => 1.9.5 
    vinxi: ^0.5.3 => 0.5.3