solid-start icon indicating copy to clipboard operation
solid-start copied to clipboard

fix: vite config types

Open huseeiin opened this issue 9 months ago • 6 comments

now you'll get better type hints

PR Checklist

Please check if your PR fulfills the following requirements:

  • [ ] Addresses an existing open issue: fixes #000
  • [ ] Tests for the changes have been added (for bug fixes / features)

What is the current behavior?

What is the new behavior?

Other information

huseeiin avatar Mar 18 '25 20:03 huseeiin

Deploy Preview for solid-start-landing-page ready!

Name Link
Latest commit 7f852642b78fb880e00538171f1f9afac753b266
Latest deploy log https://app.netlify.com/projects/solid-start-landing-page/deploys/6891d374b9c9a400080c2587
Deploy Preview https://deploy-preview-1856--solid-start-landing-page.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

netlify[bot] avatar Mar 18 '25 20:03 netlify[bot]

⚠️ No Changeset found

Latest commit: 7f852642b78fb880e00538171f1f9afac753b266

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

changeset-bot[bot] avatar Mar 20 '25 17:03 changeset-bot[bot]

this also adds extensions to output .d.ts files so that projects with moduleResolution: "nodenext" can consume @solidjs/start, this doesn't change solid's moduleResolution.

huseeiin avatar Mar 20 '25 18:03 huseeiin

@atilafassina , is this Contrib CI check blocking because of the heseeiin:main is the main branch and not a feature branch? can we turn that piece of the check off?

birkskyum avatar Mar 20 '25 19:03 birkskyum

also added brotli compression in bun

huseeiin avatar Jun 25 '25 20:06 huseeiin