feat: add function name to _server paths
fixes #1795
What is the current behavior?
Currently we dont add any path in the _server route
What is the new behavior?
The extracted function name is now added eg _server/function-name
Other information
This approach however seems flaky because it depends on the way that the Tanstack server function plugin is extracting and then constructing the ids which is "filepath--function-name_query" This looks like it is prone to change and does not provide guarantees.
I did see that Tankstack plugin does have the filename but seems like its not in the returned options so it might be stripped off somewhere or I missed it.
⚠️ No Changeset found
Latest commit: 188cb6460bab0269b26a2f89e8339ba83ef487f6
Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.
This PR includes no changesets
When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types
Click here to learn what changesets are, and how to add one.
Click here if you're a maintainer who wants to add a changeset to this PR
Deploy Preview for solid-start-landing-page ready!
| Name | Link |
|---|---|
| Latest commit | 188cb6460bab0269b26a2f89e8339ba83ef487f6 |
| Latest deploy log | https://app.netlify.com/sites/solid-start-landing-page/deploys/67acd7c4455a650008726b1e |
| Deploy Preview | https://deploy-preview-1802--solid-start-landing-page.netlify.app |
| Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site configuration.
More templates
- example-bare
- example-basic
- example-hackernews
- example-experiments
- example-notes
- example-todomvc
- example-with-auth
- example-with-authjs
- example-with-drizzle
- example-with-mdx
- example-with-prisma
- example-with-solid-styled
- example-with-tailwindcss
- example-with-trpc
- example-with-unocss
- example-with-vitest
npm i https://pkg.pr.new/@solidjs/start@1802
commit: 188cb64
Yeah this could have changed when we moved to the tanstack server functions. I think the id and name changed a bit.
Would this solve the issue or is this different? https://github.com/solidjs/solid-start/pull/1872
Do we still want to go ahead with this @loetjvr ?
@brenelz I haven't been following along as to where you are in removing Vinxi, cause that is where the issue is I believe. So might be best just to close this PR as I think it will be resolved with the current roadmap.