solid-start icon indicating copy to clipboard operation
solid-start copied to clipboard

[Feature?]: show function name in _server routes

Open loetjvr opened this issue 10 months ago • 2 comments

Duplicates

  • [x] I have searched the existing issues

Latest version

  • [x] I have tested the latest version

Summary 💡

Currently all server function calls use _server route. It would be easier to log and debug errors if the route has more details eg _server/function-name.

As I understand anything going to _server will be processed in the same function and is just looking for id and name search prop. So I propose we just add the function name to the url and dont change anything on the logic side.

I am not sure if function extraction is handled by Solid start or Vinxi and also if function name is the name of the function it extracts from or just random cause I am not always able to get a readable function name.

Examples 🌈

Image

Motivation 🔦

We find that with our logging and debugging that having everything go to the same url makes it difficult to know which function is being called and thus difficult to resolve issues or to setup proper observability.

loetjvr avatar Feb 11 '25 06:02 loetjvr

Hey, @ryansolid I think we'll need your 2cents on this one.

@loetjvr raises a good point on improving observability of our server-functions, but I'm unsure how this unfolds in our architecture and if there would be another way to achieve that.

atilafassina avatar Feb 13 '25 17:02 atilafassina

it does seem like Tanstack is suggesting to add something in the path looking at the readme

Image

https://github.com/TanStack/router/tree/main/packages/server-functions-plugin#providing-the-wrapper-implementations

loetjvr avatar Feb 14 '25 00:02 loetjvr