Remove map and createStore from mount.ts

[thetarnav]

I don't know if I'm missing something or is this a leftover, but the weak map is only being written to and the props object doesn't get changed, so it doesn't need to be a store. I don't like when stores are added to the bundle for no reason.

[changeset-bot[bot]]

⚠️ No Changeset found

Latest commit: 1f5b48de5b68c321ddcbb1f946edefe7a4a97dca

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

💥 An error occurred when fetching the changed packages and changesets in this PR

Some errors occurred when validating the changesets config:
The package "solid-start-docs" depends on the ignored package "solid-start-mdx", but "solid-start-docs" is not being ignored. Please add "solid-start-docs" to the `ignore` option.

[pkg-pr-new[bot]]

Open in Stackblitz

More templates

• example-bare
• example-basic
• example-experiments
• example-hackernews
• example-notes
• example-todomvc
• example-with-auth
• example-with-authjs
• example-with-drizzle
• example-with-mdx
• example-with-prisma
• example-with-solid-styled
• example-with-tailwindcss
• example-with-trpc
• example-with-unocss
• example-with-vitest

npm i https://pkg.pr.new/@solidjs/start@1650

commit: 1f5b48d

[ryansolid]

It's because the implementation present here is only half of the implementation. The Store was there when we had islands routing mode which could write to the props.

[atilafassina]

@thetarnav are we ok to close this PR? Or are you currently able to find it in a client bundle?

[thetarnav]

I'm fine I just noticed this during my unfinished hackathon project and decided to make a pr If the fix is incorrect feel free to close this