solid-start icon indicating copy to clipboard operation
solid-start copied to clipboard
verified publisher icon solidjs

Fix HMR issues with routeData and server functions

Open nksaraf opened this issue 3 years ago • 3 comments

There are a bunch of HMR related issues with routeData and server functions that need special consideration. @ghalle has been working on some fixes but this probably requires additional thought about how to approach this.

These PRs are contributing towards this:

  • [ ] #149

nksaraf avatar Jun 28 '22 10:06 nksaraf

I'm seeing '"request" is not available on the client. Use it within an if (isServer)'-errors while playing with the with-auth-example when not server-rendering. Is this known/expected? As this error-description is a bit vague, I'm unsure if this needs an issue or would be a duplicate.

benbender avatar Jul 16 '22 08:07 benbender

This is a weird issue with vite codesplitting..should be fixed by https://github.com/solidjs/solid-start/commit/aae4836fbebba7315de3a2a8bc4321bad8829e29

nksaraf avatar Jul 16 '22 22:07 nksaraf

Can confirm! Fixed for me in 0.1.0-alpha.92. Thank you!

benbender avatar Jul 17 '22 06:07 benbender

In setting up for SolidStarts next Beta Phase built on Nitro and Vinxi we are closing all PRs/Issues that will not be merged due to the system changing. If you feel your issue was closed in mistake. Feel free to re-open it after updating/testing against 0.4.x release. Thank you for your patience.

See https://github.com/solidjs/solid-start/pull/1139 for more details.

ryansolid avatar Dec 18 '23 21:12 ryansolid