solid-start icon indicating copy to clipboard operation
solid-start copied to clipboard

improved theme selector focused item contrast in light theme

Open puntogris opened this issue 1 year ago • 1 comments

PR Checklist

Please check if your PR fulfills the following requirements:

  • [ ] Tests for the changes have been added (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • [x] Bugfix
  • [ ] Feature
  • [ ] Code style update (formatting, local variables)
  • [ ] Refactoring (no functional changes, no api changes)
  • [ ] Build related changes
  • [ ] CI related changes
  • [ ] Documentation content changes
  • [ ] infrastructure changes
  • [ ] Other... Please describe:

What is the current behavior?

When using light theme the themes selector item focused text color is difficult to see(dark text on dark background). before

What is the new behavior?

Changed the color to light text on dark background on light theme to provide more contrast when focused. after

Other information

puntogris avatar May 25 '24 00:05 puntogris

⚠️ No Changeset found

Latest commit: 96310589d58897da0cf21578832c1e42e1e8273f

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

changeset-bot[bot] avatar May 25 '24 00:05 changeset-bot[bot]

Thanks

ryansolid avatar May 28 '24 15:05 ryansolid