solid-start icon indicating copy to clipboard operation
solid-start copied to clipboard

Add example with-drizzle

Open thednp opened this issue 1 year ago • 3 comments

PR Checklist

Please check if your PR fulfills the following requirements:

  • [ ] Tests for the changes have been added (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • [ ] Bugfix
  • [x] Feature
  • [ ] Code style update (formatting, local variables)
  • [ ] Refactoring (no functional changes, no api changes)
  • [ ] Build related changes
  • [ ] CI related changes
  • [ ] Documentation content changes
  • [ ] infrastructure changes
  • [ ] Other... Please describe:

What is the current behavior?

No example with a major growing ORM, Drizzle.

What is the new behavior?

Now we have an example similar to with-prisma but for drizzle.

Other information

Drizzle is an awesome ORM, SolidStart examples need something like this.

thednp avatar May 23 '24 19:05 thednp

⚠️ No Changeset found

Latest commit: ad9e9e49c2232391286b8bb13591ab39d46897f6

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

changeset-bot[bot] avatar May 23 '24 19:05 changeset-bot[bot]

Yeah those sort of ambient types have been giving me trouble a bit. And they seem to work differently outside and inside of the repo. Let's merge and see. Although the CLI will need to be updated to add this example.

ryansolid avatar May 23 '24 21:05 ryansolid

Yeah those sort of ambient types have been giving me trouble a bit. And they seem to work differently outside and inside of the repo. Let's merge and see. Although the CLI will need to be updated to add this example.

I don't know everything in the Solid code base, but I'm sure it's something quick for you.

thednp avatar May 24 '24 04:05 thednp

Thanks

ryansolid avatar May 28 '24 15:05 ryansolid