solid-start icon indicating copy to clipboard operation
solid-start copied to clipboard

build(with-vitest): :heavy_plus_sign: add missing dependencies

Open seahindeniz opened this issue 1 year ago • 5 comments

PR Checklist

Please check if your PR fulfills the following requirements:

  • [ ] Tests for the changes have been added (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • [ ] Bugfix
  • [ ] Feature
  • [ ] Code style update (formatting, local variables)
  • [ ] Refactoring (no functional changes, no api changes)
  • [x] Build related changes
  • [ ] CI related changes
  • [ ] Documentation content changes
  • [ ] infrastructure changes
  • [ ] Other... Please describe:

What is the current behavior?

When I run pnpm test and pnpm coverage in the with-vitest example, I get the following errors

  • Error [ERR_MODULE_NOT_FOUND]: Cannot find package 'vite-plugin-solid'
  • MISSING DEPENDENCY Cannot find dependency '@vitest/coverage-v8'

What is the new behavior?

Without the missing required dependencies, the scripts will run as expected

Other information

seahindeniz avatar May 22 '24 21:05 seahindeniz

⚠️ No Changeset found

Latest commit: 6be64349d5d699add2e902df774a0f8287f44dcd

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

changeset-bot[bot] avatar May 22 '24 21:05 changeset-bot[bot]

Original author of that template here:

If you configure coverage to be collected, the package will be automatically installed. For those who don't collect it, it's a superfluous package, which is the reason it is not installed by default.

atk avatar May 23 '24 04:05 atk

Hey @atk 👋. I added it because having a script to collect coverage with a missing dependency creates a bit unexpected visual for the first comer. At least that's how I felt first after trying out every script and then felt the urge to add them. First time users may even say this is a bug. IMHO, the choice must start from the point of creating the script, rather then starting with and error 🙏

seahindeniz avatar May 23 '24 05:05 seahindeniz

If that is the case then let us remove the script and add the ability to collect coverage to the documentation.

atk avatar May 23 '24 05:05 atk

Just removed the script and the dep. I'm not sure how you mean document it but let me know what to add and where, I can assist, or please do a commit

seahindeniz avatar May 23 '24 06:05 seahindeniz

Thanks

ryansolid avatar May 23 '24 15:05 ryansolid