solid-site icon indicating copy to clipboard operation
solid-site copied to clipboard

Simple Todos Hyperscript demo is broken

Open just-boris opened this issue 11 months ago • 1 comments

Describe the bug

This demo does not work: https://www.solidjs.com/examples/simpletodoshyperscript

After adding the first todo item, all other items do not get added. There is an error in browser console

sdk.js:1 Uncaught Error: DOMNode._children is expected to not be null.
    at Tn.insertChild (sdk.js:1:257639)
    at Pn.childNodeInserted (sdk.js:1:268559)
    at Ln.childNodeInserted (sdk.js:1:273663)
    at g.dispatch (protocol_client.js:1:7253)
    at j.dispatch (protocol_client.js:1:8244)
    at d.onMessage (protocol_client.js:1:4221)
    at sdk.js:1:341593

Your Example Website or App

https://www.solidjs.com/examples/simpletodoshyperscript

Steps to Reproduce the Bug or Issue

  1. Go to https://www.solidjs.com/examples/simpletodoshyperscript
  2. Try adding new todo items
  3. After adding the first one, they stop working

Expected behavior

The demo should work

Screenshots or Videos

See the attached video. The recording uses Chrome v134, but I see the same in Firefox 136 too (both are latest stable versions)

https://github.com/user-attachments/assets/c16e6f4a-fb68-4a95-b248-0177e92487a2

Platform

  • OS: n/a
  • Browser: Chrome v134, Firefox 136

Additional context

No response

just-boris avatar Mar 23 '25 20:03 just-boris

Thanks. It does looks like something changed here over time. Top level arrays aren't working. It looks like it wants a fragment or atleast a hyperscript function. Wrapping the arguments. I think this happened several versions back when we fixed context.

We should update the website. https://playground.solidjs.com/anonymous/e12d45bd-5925-45f6-b529-83527ec9d1f8

ryansolid avatar Mar 26 '25 23:03 ryansolid