solid-playground icon indicating copy to clipboard operation
solid-playground copied to clipboard

Upgrade playground to new worker import syntax

Open timotius02 opened this issue 3 years ago • 4 comments

#86

timotius02 avatar Mar 20 '22 11:03 timotius02

Thanks! This is looking good. Unfortunately, I'm seeing a bunch of errors :/

image

Not entirely sure where this is coming from

amoutonbrady avatar Apr 02 '22 16:04 amoutonbrady

Yeah it's looking like its a more complicated migration than I thought, specifically importing from node_modules. I'll be asking around the Vite discussion boards if anyone has any idea on this, but this is probably out of the scope of my current understanding.

timotius02 avatar Apr 02 '22 19:04 timotius02

I figured this wouldn't be an easy task. We also need to think how and if this can affect the library mode (solid-repl). I'll put this PR in draft for the moment while you (or anyone else) investigate the matter if you don't mind :)

amoutonbrady avatar Apr 03 '22 08:04 amoutonbrady

I would guess the issue is that vite can't statically analyze createWorker and so throws an error? Does that match what you've discovered? Also, this will not affect library mode because it only changes the /playground folder (but we should make sure it works in both dev and prod)

milomg avatar Jun 18 '22 04:06 milomg