solid-playground icon indicating copy to clipboard operation
solid-playground copied to clipboard

Incorrect file extensions published to npm

Open NullVoxPopuli opened this issue 1 year ago • 3 comments

Just saw image

(I'm poking around!) :D

And there is non-JS syntax in here.

I believe that should be compiled away yeah? (or if the consuming project is responsible for further-compiling the library, the file extension should be jsx, yeah?)

thanks! (lemme know if I misunderstand something! <3)

NullVoxPopuli avatar Jul 24 '24 16:07 NullVoxPopuli

omg, I missed that this is all in a string. everything is fine.

MORE COFFEE

NullVoxPopuli avatar Jul 24 '24 16:07 NullVoxPopuli

actually no, I think I still have a question about use of jsx in a published package:

image

This file doesn't need to be jsx tho :thinking: image

NullVoxPopuli avatar Jul 24 '24 16:07 NullVoxPopuli

I believe we mark the root as jsx so that vite compiles the package with babel (otherwise we've had problems with it skipping the SolidJS transform for this package)

milomg avatar Aug 11 '24 18:08 milomg