Bug? No login button on https://playground.solidjs.com/

Open birkskyum opened this issue 1 year ago • 2 comments

I don't remember if there should be a Login button in the deployed version.

I see it locally, both in dev and in build+start.

Mar 25 '24 04:03 birkskyum

I've deployed the legacy branch which disables login and supports old hashes

Cc @davedbase, do you remember why we turned off login? Something to do with sharing anonymous repls not working on the backend?

Mar 25 '24 04:03 milomg

@modderme123 I seem to remember the fact that iframes can escape their sandboxing being an issue here, where a user could send a link with malicious playground code which steals their session token and sends to a backend somewhere. Is this still an issue?

Mar 29 '24 15:03 Tommypop2