solid-meta icon indicating copy to clipboard operation
solid-meta copied to clipboard

Fix removing one <title> renders all previous <title>s

Open yume-chan opened this issue 1 year ago • 0 comments

removeTag missing a break causing all previous <title> tags to be rendered.

Repro playground: https://playground.solidjs.com/anonymous/4fa1f8e7-fcb6-4f6c-a521-daf6207fc779 (looks like @solidjs/meta doesn't work well with HMR, so I need to refresh the preview every time I edited the source code)

For whatever reason, I need to add babel-jest package to root package.json for tests to run. I installed with [email protected] but it still dramatically changed the lockfile, however, it didn't add any new packages.

Output from pnpm test after cloning and pnpm i:

~/solidjs/solid-meta main 3s
❯ pnpm test

> @solidjs/[email protected] test /home/solidjs/solid-meta
> jest && npm run test:types

: ● Validation Error:

  Module babel-jest in the transform option was not found.
         <rootDir> is: /home/solidjs/solid-meta

  Configuration Documentation:
  https://jestjs.io/docs/configuration.html

 ELIFECYCLE  Test failed. See above for more details.

yume-chan avatar Oct 23 '24 16:10 yume-chan