solid-jest icon indicating copy to clipboard operation
solid-jest copied to clipboard

Add TypeScript support and Use preset-env

Open aminya opened this issue 4 years ago • 3 comments

Fixes #2

I added these extras by default. However, we can put them behind a process.env.BABEL_EXTRAS config (or a new set of presets) if you prefer that the default config only use babel-solid-js

aminya avatar May 14 '21 15:05 aminya

This package should be focused on solid support in jest rather than a general solution. Let's not bloat it and instead continue to give the consumer control over what additional transforms are performed.

maxmilton avatar May 31 '21 06:05 maxmilton

I tend to agree with @maxmilton. I'd love to hear more opinions but I'm inclined to close this one.

ryansolid avatar Aug 09 '21 02:08 ryansolid

As I said, we can put this behind a config, and move the dependencies to optionalDependencies. If the improvements are composable there is no need to avoid them.

aminya avatar Aug 09 '21 05:08 aminya