solid-docs icon indicating copy to clipboard operation
solid-docs copied to clipboard

Tutorial page example https://www.solidjs.com/tutorial/bindings_refs?solved doesn't work

Open aercolino opened this issue 2 years ago • 2 comments

Describe the bug

1st problem

The URL for the logo is given as https://dev.solidjs.com/img/logo/dark-without-wordmark/logo.svg but it should probably be https://www.solidjs.com/img/logo/dark-without-wordmark/logo.svg

2nd problem

I see two logos (macOS 12.5.1 + Chrome 105 / Firefox 104): one appears inside the canvas, and another appears inside the body. My solution has been to apply the mask to .my-canvas class instead of the canvas element.

image

Your Example Website or App

https://www.solidjs.com/tutorial/bindings_refs?solved

Steps to Reproduce the Bug or Issue

Reproduce

  1. Go to https://www.solidjs.com/tutorial/bindings_refs?solved
  2. Look at the results tab

Expected behavior

To see the one logo with animated colors inside the canvas

Screenshots or Videos

No response

Platform

  • OS: macOS 12.5.1
  • Browser: Chrome 105, Firefox 104, maybe others too

Additional context

Fix for the 1st problem

  1. Display the style.css tab
  2. Replace dev with www

Fix for the 2nd problem

  1. Replace canvas with my-canvas
  2. Display the main.jsx tab
  3. Add class="my-class" to the canvas element

aercolino avatar Sep 05 '22 15:09 aercolino

The cause of the second logo is due to the fact that there is a div with a class luna-dom-highlighter which includes a second canvas element...

image

aercolino avatar Sep 05 '22 16:09 aercolino

Thanks I've transferred this issue to docs.

ryansolid avatar Sep 06 '22 03:09 ryansolid

Deploy Preview for solid-docs ready!

Name Link
Latest commit 466d33c4a8464136a4b1dee55634d205c5e95acd
Latest deploy log https://app.netlify.com/sites/solid-docs/deploys/63c65c095ac47b00094b1955
Deploy Preview https://deploy-preview-188--solid-docs.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

netlify[bot] avatar Jan 17 '23 08:01 netlify[bot]