solid-primitives icon indicating copy to clipboard operation
solid-primitives copied to clipboard

Updates tauri-storage for Tauri 2 stable

Open bpevs opened this issue 8 months ago • 6 comments

The api for plugin-store has changed since the last commit. This pr updates that, and allows for passing store options obj.

bpevs avatar Apr 25 '25 06:04 bpevs

⚠️ No Changeset found

Latest commit: 08167dd6e3b8fb994d97ac3604daeb39877f450e

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

changeset-bot[bot] avatar Apr 25 '25 06:04 changeset-bot[bot]

There might still be projects using v1, so I would prefer to split the module.

atk avatar Apr 25 '25 21:04 atk

oh this is meant to be compatible with v1? I didn't realize the apis were exactly the same; the example app uses 2.0-beta. To be clear, thr changes I was meaning to address were the api changes between tauri 2.0-alpha and tauri 2.0 stable.

edit: I think the first version of @tauri-apps/plugin-store was already targeted at 2.0-alpha: https://www.npmjs.com/package/@tauri-apps/plugin-store/v/2.0.0-alpha.0

bpevs avatar Apr 26 '25 00:04 bpevs

No, it's just that support for both is on my to-do list.

atk avatar Apr 26 '25 04:04 atk

Okie. Mmmm If you want me to format/split this in a particular way, I don't mind making a few changes to help. But I'm not sure on your preferences on how to split, and with this small amount of code, I feel like the communication might be more work than just making the actual edits.

So feel free to directly edit/close/do whatever with this pr, if it's easier. I was just making the pr since I had already made these updates locally to support my app.

bpevs avatar Apr 26 '25 12:04 bpevs

I had not yet decided whether to call the sub-modules tauri-v2/-v1 or tauri/-legacy or transparently support both.

atk avatar Apr 26 '25 14:04 atk

Oh no, why has it been closed?

vincehi avatar Oct 07 '25 12:10 vincehi

oh.... oops. I forgot about this issue, and deleted my fork while cleaning up. I haven't been using solid or tauri recently as much recently anyways, though, so I don't really want to put in the effort to double check if anything has changed in the last 6 months. It's just a small change, so anyone feel free to recreate the change from the diff if you need.

bpevs avatar Oct 09 '25 21:10 bpevs