solid-primitives icon indicating copy to clipboard operation
solid-primitives copied to clipboard

fix: stage badge for specific primitive

Open jaysencpp opened this issue 10 months ago • 3 comments

The stage badge is not displaying correctly.

Relevant issue: #757

This was already fixed for the badges shown on the front page (#759), however it's not fixed for a specific primitive's page.

To reproduce error:

  • Open any primitive specific page (e.g. https://primitives.solidjs.community/package/active-element)
  • See that the Stage is not correct.

jaysencpp avatar Mar 02 '25 18:03 jaysencpp

⚠️ No Changeset found

Latest commit: ade1d875d954bbdc52be515cd862ffa30b5c58a1

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

changeset-bot[bot] avatar Mar 02 '25 18:03 changeset-bot[bot]

The fix is already on main, we just need to roll it out.

atk avatar Mar 02 '25 22:03 atk

The fix is already on main, we just need to roll it out.

Oh, that's great. Though I'm not quite sure what you mean by that since what I'm seeing on the main branch is wrong: https://github.com/solidjs-community/solid-primitives/blob/main/site/src/routes/package/%5Bname%5D/(package).tsx#L43

jaysencpp avatar Mar 03 '25 06:03 jaysencpp

Sorry @jaysencpp, I didn't realize you made the correct fix, I went ahead and pushed a fix https://github.com/solidjs-community/solid-primitives/pull/793 and the live site shows the correct stage badge now.

Thank you so much for taking the time to fix this, had I seen your PR first, I would have merged it

aquaductape avatar May 31 '25 21:05 aquaductape