solid-primitives icon indicating copy to clipboard operation
solid-primitives copied to clipboard

Rewrite build script to build all packages in one process (Removes CJS)

Open thetarnav opened this issue 1 year ago • 2 comments

Rewrites build script to build all packages in one process Similarly to how testing works So no turborepo cashing, but it's much faster overall 5s to build all packages instead of a couple of minutes So should be much easier for new people to fork and build locally and not have to wait so much Also website deploys could happen on main now as the netlify build should be a lot faster

Proper turbo-like caching could be added later as well and be used for tests too, without sacrificing the time to build all packages.

Please run rm -rf packages/*/dist/* and rm -rf .turbo to clear old outputs

This also removes CJS support

thetarnav avatar Sep 29 '24 12:09 thetarnav

🦋 Changeset detected

Latest commit: dae3b77385e69fee844f488f141b38bf7fc892e3

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

changeset-bot[bot] avatar Sep 29 '24 12:09 changeset-bot[bot]

Since the removal of CJS support might be considered a breaking change, shouldn't this be a major update? Minor breaking changes are a violation of semver.

Also, in CONTRIBUTING.md, the design maxim number 12 still includes CJS support.

atk avatar Sep 29 '24 19:09 atk

@atk it's not yet done I'm experimenting with using tsc -b for building now. Then esbuild will be necessary only for the two packages that use jsx - controlled-props and virtual.

thetarnav avatar Jan 15 '25 19:01 thetarnav