solid-primitives
solid-primitives copied to clipboard
Fix `start` `useRequest` import
Fixed the import statement directed at the jsx file:
import { useRequest } from "solid-start/server/ServerContext.jsx";
Resolution:
import { useRequest } from "solid-start/server";
⚠️ No Changeset found
Latest commit: 7705d154a1af215966ea708ec6a44dad7cbcd939
Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.
This PR includes no changesets
When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types
Click here to learn what changesets are, and how to add one.
Click here if you're a maintainer who wants to add a changeset to this PR
As I remember .jsx was because of NodeNext node resolution.
SolidStart doesn't include extensions when reexporting in server.ts, which breaks the resolution.
I would like to "fix" the import as well, but solid-start needs fixing first probably.
You can see it breaking the build.
Also we should probably move to @solidjs/start package.
Also we should probably move to @solidjs/start package.
Then let's get this merged first https://github.com/solidjs-community/solid-primitives/pull/585 and then I will do a followup pr that fixes the import.
Fixed in https://github.com/solidjs-community/solid-primitives/pull/660