solidproject.org icon indicating copy to clipboard operation
solidproject.org copied to clipboard

History

Open michielbdejong opened this issue 1 year ago • 7 comments

michielbdejong avatar Feb 14 '24 15:02 michielbdejong

Need to fix the layout

michielbdejong avatar Feb 14 '24 15:02 michielbdejong

I rebased on 2023-redesign. The layout of this page still needs some love: Screenshot 2024-06-11 at 10 24 39

I'm not the right person to work on that though, maybe a frontend developer can have a look? Will leave this open as a draft PR in case someone wants to pick it up.

michielbdejong avatar Jun 11 '24 08:06 michielbdejong

Deploy Preview for musical-sawine-26ffa9 ready!

Name Link
Latest commit 078c072700aef489f5494533a59e02a3ab9006c8
Latest deploy log https://app.netlify.com/sites/musical-sawine-26ffa9/deploys/666c1a4e4250f10008520233
Deploy Preview https://deploy-preview-847--musical-sawine-26ffa9.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] avatar Jun 11 '24 15:06 netlify[bot]

@TallTed @michielbdejong There were way too many changes to do such that it was easier to push this commit https://github.com/solid/solidproject.org/pull/847/commits/b0247f1e7dbefd4a0d153ffe724c0e7c3ce501e6 (including "markup, stylesheet, links/references, RDFa, editorial and content changes") instead of making inline suggestions through GitHub's UI. It is a take it or leave it.

@TallTed I've done some minor editorial changes as well as proposing changes mentioned in https://github.com/solid/solidproject.org/issues/840#issuecomment-1991391596 as an initial pass I think you should continue to review this article and also perhaps check for accuracy / relevancy. The article still seems like a draft but it can be improved - whether through your and/or others changes (and over time).

@timbl Have a look.

csarven avatar Jun 11 '24 15:06 csarven

rendering is still not great but better than nothing I think: Screenshot 2024-06-13 at 11 17 23

As a possible improvement, do you think you could center the white rectangle and maybe give it rounded corners, like on the main /about.html page?

Only real rendering bug I see is the aspect ratio of the avatar in the 'More details about this document' view, it's very wide and not very high: Screenshot 2024-06-13 at 11 20 20

michielbdejong avatar Jun 13 '24 09:06 michielbdejong

Here is that same avatar but in its correct aspect ratio: https://www.w3.org/Press/Stock/Berners-Lee/2001-europaeum-eighth.jpg

michielbdejong avatar Jun 13 '24 09:06 michielbdejong

@michielbdejong are you still wanting to pursue this PR?

jeswr avatar Nov 22 '24 17:11 jeswr