test-suite icon indicating copy to clipboard operation
test-suite copied to clipboard

Objective of the test suite

Open kjetilk opened this issue 5 years ago • 5 comments

We need to decide whether the test suite should align closely with the spec, or with NSS as of now. I started to do the latter, but believe now that the former is the right approach.

kjetilk avatar Feb 25 '20 23:02 kjetilk

Unless someone speaks up, I will adapt the test suite to conform to the spec going forward.

kjetilk avatar Mar 11 '20 15:03 kjetilk

If you find that they are different, then you have to figure out whether it is a bug with NSS or a bug with the spec. Don't assume one or the other. If it isn't obvious which is wrong, then raise an issue with both and escalate it

timbl avatar Mar 11 '20 20:03 timbl

Yes, indeed, that is the idea. We are sticking to NSS as the guideline, but oftentimes, it has been underdefined. For example, you can ask NSS to create a Non-RDF resource but at the same time declare that it is a container with a Link header. NSS will do that without complaint, but now we say that it is an internally inconsistent situation. People are unlikely do have ever tried to do it, because it is a silly thing to do, but we shouldn't have those kinds of inconsistencies, and so we have quite a lot of tests that NSS is failing. Those doesn't change the way Solid has de facto been behaving, but it rectifies the ways that have been underdefined.

kjetilk avatar Mar 11 '20 21:03 kjetilk

This comment is an example of one of the more ambiguous issues I have encountered: https://github.com/solid/specification/issues/40#issuecomment-585154494

kjetilk avatar Mar 12 '20 10:03 kjetilk

Related: as an interim solution, should the NSS repo state that it reflects solid-spec (as opposed to solid/specification) .. and that the current solid/test-suite may give different results?

csarven avatar Mar 19 '20 11:03 csarven