solid-cli icon indicating copy to clipboard operation
solid-cli copied to clipboard

Prevent case that login search string is empty

Open linonetwo opened this issue 6 years ago • 4 comments

Might prevent a situation like https://github.com/solid/solid-cli/issues/8

linonetwo avatar Jan 08 '20 05:01 linonetwo

Ok, I simply throw an error instead.

linonetwo avatar Jan 10 '20 06:01 linonetwo

I'm going to add a test case, using jest.

linonetwo avatar Jan 11 '20 03:01 linonetwo

const request = https.request(options);

isn't easy to mock using jest-fetch mock, would you mind I refactor it to node-fetch?

linonetwo avatar Jan 11 '20 09:01 linonetwo

I think that should be fine @linonetwo

jaxoncreed avatar Jan 28 '20 19:01 jaxoncreed