solid-cli icon indicating copy to clipboard operation
solid-cli copied to clipboard

Published 20 hours ago • verified publisher icon solid-contrib

should @trust be moved?

Open melvincarvalho opened this issue 6 years ago • 4 comments

dont mean to be a pain, but I was trying to do some debugging in this code, and want to make sure I'm looking at the most recent code base (as a learning experience)

https://github.com/solid/solid-cli/blob/master/src/SolidClient.js#L4

has @trust moved to @solid ?

melvincarvalho avatar Oct 07 '18 21:10 melvincarvalho

I think so, but @justinwb would be the authority on this, I think.

kjetilk avatar Oct 07 '18 21:10 kjetilk

Yes, repo predates that move. Should upgrade.

RubenVerborgh avatar Oct 07 '18 21:10 RubenVerborgh

Yeah so we moved most (not all) of the @trust dependencies over to the @solid namespace - but this one was included. I believe this is the full list:

jose keychain oidc-op oidc-rp oidc-rs

justinwb avatar Oct 08 '18 00:10 justinwb

I'm getting bitten by this because there is a bunch of security warnings from base64url, and this appears to be the one that is causing the alarm. Would be great if it could be upgraded.

kjetilk avatar Jun 06 '19 21:06 kjetilk