sgn icon indicating copy to clipboard operation
sgn copied to clipboard

allow nirs upload with plot ids

Open lukasmueller opened this issue 2 years ago • 4 comments

Expected Behavior

For Bugs:

Environment

Steps to Reproduce

lukasmueller avatar Jul 11 '22 15:07 lukasmueller

@nickmorales, @jmh579 it looks like this functionality used to exist, but was removed. Was there a reason to restrict uploads to samples only that we are missing?

Screenshot from 2022-07-20 12-41-37, @

bellerbrock avatar Jul 20 '22 16:07 bellerbrock

@bellerbrock I think that it was changed because you can have scans from multiple different tissues per plot, each tissue will give a different spectral pattern. With plot-level data, it isn't clear which tissue was scanned. This could lead to the averaging of scans from different tissues, which we don't want.

There might be a better way to specify tissue type within the high dimensional phenotype storage itself to avoid having to create a bunch of different tissue samples within the database. I can bring it up with the BrAPI High Dimensional Phenotypes group on Friday. I'll send you a slack message with the meeting info in case you want to join.

jmh579 avatar Jul 20 '22 17:07 jmh579

Thanks @jmh579 . Per the discussion today in the high-dimensional phenotypes weekly meeting:

  • It's crucial to have high-dimensional phenos linked to the specific tissues on which they were made. Plot and plant ids are not specific enough, tissue samples are necessary.
  • Stopping and manually creating a sampling trial and tissue sample ids before upload is a lot to ask, especially of programs that only work with one tissue.

Proposed solution: Let users use plot/plant ids in their upload file. But have them select the relevant tissue in a dropdown, and create a sampling trial and tissue sample ids in the background during the upload.

bellerbrock avatar Jul 22 '22 19:07 bellerbrock

@bellerbrock I like that idea, can you implement it?

lukasmueller avatar Sep 13 '22 14:09 lukasmueller

Working on this now. Another scenario to make sure to address - cases where technical replicates (many spectra collected on the same processed sample) are included in the nirs upload

bellerbrock avatar Dec 06 '22 21:12 bellerbrock

Has this been implemented? If so, we should close the ticket.

lukasmueller avatar May 18 '23 14:05 lukasmueller