sgn icon indicating copy to clipboard operation
sgn copied to clipboard

Mixed Model Tool Issues

Open ch728 opened this issue 3 years ago • 7 comments

Started playing around with the mixed model tool a little. I noticed a couple of issues.

  1. There is no way to specify a nesting of variables, only interaction. It is common to nest rep in location to make unique rep factor for example.
  2. After running a model the results are shown with no header for the traits (see below) and there is no way to download the result. Screenshot from 2022-01-27 15-57-21
  3. The save button allows one to save the analysis in the database (models can be saved though); however, this doesn't seem to work yet as I get this error message when trying to save the analysis: Screenshot from 2022-01-27 16-01-03

I understand this is a newer tool and under active development, just wanted to provide some (hopefully) useful feedback!

ch728 avatar Jan 27 '22 21:01 ch728

Hi Chris, do you have a location called [Computation] in the database? That's what the tool uses as location. Sometimes users delete this location because they think it is not useful

lukasmueller avatar Jan 28 '22 20:01 lukasmueller

There is a ticket for adding nested variables. I thought there was a download, if not we should definitely add that option and have proper headers.

lukasmueller avatar Jan 28 '22 20:01 lukasmueller

I definitely deleted the Computation location. Can I simply add a location called Computation to fix this?

ch728 avatar Jan 29 '22 14:01 ch728

Yes. It has to be called [Computation] (with the brackets) Maybe we should change this or prevent it from getting deleted. cheers Lukas


From: Chris Hernandez @.> Sent: Saturday, January 29, 2022 9:19 AM To: solgenomics/sgn @.> Cc: Lukas A. Mueller @.>; Assign @.> Subject: Re: [solgenomics/sgn] Mixed Model Tool Issues (Issue #3922)

I definitely deleted the Computation location. Can I simply add a location called Computation to fix this?

— Reply to this email directly, view it on GitHubhttps://github.com/solgenomics/sgn/issues/3922#issuecomment-1024920730, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AAAV7F3AI7UKARDNVSOSGX3UYPZQXANCNFSM5M7BFP7Q. Triage notifications on the go with GitHub Mobile for iOShttps://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Androidhttps://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub. You are receiving this because you were assigned.Message ID: @.***>

lukasmueller avatar Jan 29 '22 21:01 lukasmueller

added issue #3927 to prevent computation location deletion. Pull request #3928.

lukasmueller avatar Jan 31 '22 03:01 lukasmueller

Let's make this issue about adding a header and the download. (nesting already has an issue.)

lukasmueller avatar Jan 31 '22 03:01 lukasmueller

Okay, sounds good. I added the [Computation] location back and it fixed the issue with saving the analysis.

ch728 avatar Jan 31 '22 04:01 ch728

Closing this issue as a duplicate of #3997.

lukasmueller avatar Sep 12 '22 14:09 lukasmueller