sgn
sgn copied to clipboard
solgenomics
Refactor project_type, project_property, and experiment_type cvs
Expected Behavior
The existing terms are confusing.
- Basic project_types (folder, breeding_program) are not within project_type, and a basic 'trial' project_type is missing.
- It's unclear how many subtypes (different types of folders, different types trials) relate to the basic types, and they are spread across 3 cvs.
- User-facing phenotyping trial types have inconsistent formatting (capitalization, underscores vs spaces) and are sometimes duplicated.
The current state of the 3 cvs in a typical database:
| cv.name | cvterm.name |
|---|---|
| project_property | breeding_program |
| project_property | folder_for_crosses |
| project_property | folder_for_genotyping_trials |
| project_property | folder_for_trials |
| project_property | trial_folder |
| ------------- | ------------- |
| project_type | Advanced Yield Trial |
| project_type | Clonal Evaluation |
| project_type | crossing_block_trial |
| project_type | crossing_trial |
| project_type | genetic_gain_trial |
| project_type | genotyping_trial |
| project_type | grafting_trial |
| project_type | health_status_trial |
| project_type | heterosis_trial |
| project_type | misc_trial |
| project_type | phenotyping_trial |
| project_type | pollinating_trial |
| project_type | Preliminary Yield Trial |
| project_type | Regional Trials |
| project_type | Screen House |
| project_type | Seedling Nursery |
| project_type | Seed Multiplication |
| project_type | Specialty Trial |
| project_type | storage_trial |
| project_type | Uniform Yield Trial |
| project_type | Variety Release Trial |
| ------------- | ------------- |
| experiment_type | analysis_experiment |
| experiment_type | analysis_model_experiment |
| experiment_type | analytics_protocol_experiment |
| experiment_type | cross_experiment |
| experiment_type | drone_run_experiment |
| experiment_type | field_layout |
| experiment_type | genotyping_experiment |
| experiment_type | genotyping_layout |
| experiment_type | grafting_experiment |
| experiment_type | pedigree experiment |
| experiment_type | phenotyping_experiment |
| experiment_type | sampling_layout |
| experiment_type | seedlot_experiment |
| experiment_type | trained_keras_cnn_model_experiment |
| experiment_type | treatment_experiment |
For Bugs:
Environment
Steps to Reproduce
@bellerbrock it looks to me like experiment_type and the above project_property cvterms be changed to cv= project_type
Hi @nmenda @bellerbrock , I think crossing_trial project_type and cross_experiment experiment_type have correct cv. Could you please don't change cv of these two cvterms? Thanks
A few other experiment_type cvterms in that list are used in the nd_experiment
- Need to write dbpatch to populate project.type_id from projectprop
- modify code to use project.type_id, such as manage pages should show projects depending on type_id
- Every type of project creation needs to populate project.type_id correctly
@nmenda @lukasmueller I think we should use the terms genotyping_plate (not genotyping_trial), genotyping_project (not genotyping_data_project), crossing_experiment (not crossing_trial), because these terms are now well established and clearer.