sgn icon indicating copy to clipboard operation
sgn copied to clipboard

upgrade jQuery and bootstrap

Open isaak opened this issue 4 years ago • 4 comments

isaak avatar Jan 26 '21 16:01 isaak

Bootstrap upgrade from 3.x to 5.x is major. It is better done by someone who knows it good and implemented it extensively.

There is a branch here: https://github.com/solgenomics/sgn/tree/topic/upgrade-jquery-bootstrap

isaak avatar Jul 16 '21 08:07 isaak

Is it possible to upgrade to a new version of jQuery incrementally (page by page)? It seems too big of a project to upgrade all the code at once to use new jQuery. Another alternative would be to schedule a hackathon to work on this for a few days.

ClayBirkett avatar Sep 21 '21 16:09 ClayBirkett

Here are pages with upgrade notes https://jquery.com/upgrade-guide/1.9/ https://jquery.com/upgrade-guide/3.0/

I found the following important changes jQuery 1.9 deprecated the .attr() in most cases jQuery 3 changed the jqXHR return from jQuery.ajax(), replace (success, error, complete) with (done, fail, always) or use then catch methods

ClayBirkett avatar Dec 15 '21 21:12 ClayBirkett

Maybe split this in two?

lukasmueller avatar May 09 '24 15:05 lukasmueller