Soledad Galli

Results 354 comments of Soledad Galli

> parate PR for the exampl Here would be good :) Thank you!

It's looking good. I think we need to add a test to corroborate that the method get_feature_names_out returns the original features, without the ones used in the transformation, plus the...

Hey @datacubeR This is almost ready. Some small changes here and there. Would you be able to have a look? Thank you!

Hi @datacubeR Thank you for looking into the get_feature_names_out() issue. I think we can ignore that request then. Let me know when this is good to go. Thanks a lot

Thanks for the suggestion. I've heard of this before, but I have to say I am not deeply familiar with these types of embeddings and when we could/should use them....

I had a quick look at the link, and all metrics seem to return values somewhere between -1 and 1. Why do you think we need to expand the threshold...

For the standard correlation functions (spearman, pearson, kendall) the value of correlation is quite intuitive, if it is >0.7 or 0.8, then the variables are probably very related. What sort...

In the kaggle kernel you mention it is used exactly as per sklearn docs. To determine relationship with the target and not among variables. It also does not make reference...

Hi @TremaMiguel Thanks for the detail and the plots. **I hear the pros:** a fairly simple code modification, would allow the use of this technique, and virtually any other. **On...