aafm icon indicating copy to clipboard operation
aafm copied to clipboard

If a symlink points to a subdirectory within the same directory, the parent cannot be opened

Open KaiRo-at opened this issue 11 years ago • 1 comments

With the current images for the Firefox OS Flame, aafm cannot open the root directory of the device.

The issue comes down to this:

root@flame:/ # ls -l storage/
drwxrwxr-x root sdcard_rw 1970-01-01 01:00 sdcard lrwxrwxrwx root root 1970-01-08 22:57 sdcard0 -> /storage/sdcard

So, as that symlink points into the same directory it is in, the call in https://github.com/sole/aafm/blob/master/src/Aafm.py#L134 creates an endless loop and the parent of /storage (i.e. /) cannot be opened in aafm at all. I work around this by just locally changing that line to |is_directory = False| but that's obviously not the right fix. ;-)

KaiRo-at avatar Oct 04 '14 00:10 KaiRo-at

Patches welcome ;)

sole avatar Oct 06 '14 22:10 sole