hldig icon indicating copy to clipboard operation
hldig copied to clipboard

Fuzzy.cc:strings need to be marked for translation

Open andy5995 opened this issue 6 years ago • 4 comments

There are strings in this file that need to be marked for translation.

https://github.com/solbu/hldig/blob/f276b92ca3f0b59a165b878a517b38d9cd71b26f/hlfuzzy/Fuzzy.cc#L170

andy5995 avatar Sep 03 '18 02:09 andy5995

Hi, I would love to work on this issue, but I am not sure I understand your requirement. Could you give an example?

shrey183 avatar Oct 04 '18 23:10 shrey183

If you look on line 169 you find a string that is not makred for translation, but on line 175 and 176, some 6 lines below that, you'll see an example of strings that are marked for translation.

For example, in the line 169 you find this code: cout << "hlfuzzy: words: " << count << '\n'; The quoted string need to be enclosed in _().

Here is an example. I'll have the original just below so you see the difference easily: cout << _("hlfuzzy: words: ") << count << '\n'; << Fixed cout << "hlfuzzy: words: " << count << '\n'; << Original

solbu avatar Oct 05 '18 19:10 solbu

Hi, thanks for your comment, I created a Pull Request and I see this after making the pull request: image

Have I done something wrong? I am kind of new to this, so any comments from you all would be really helpful.

shrey183 avatar Oct 05 '18 21:10 shrey183

This is exactly how it's done. :-)

solbu avatar Oct 05 '18 22:10 solbu