haskell-network-anonymous-i2p
haskell-network-anonymous-i2p copied to clipboard
Spooky code
These are suggestions, act/ignore as thou wilt.
- https://github.com/solatis/haskell-network-anonymous-i2p/blob/master/src/Network/Anonymous/I2P/Protocol.hs#L61-L62 datatypes/newtypes pls - also, what if it fails to parse?
- https://github.com/solatis/haskell-network-anonymous-i2p/blob/master/src/Network/Anonymous/I2P/Protocol.hs#L88-L89 Make a Version type, preferably with a smart constructor that validates sensibility of the
[Integer]
- https://github.com/solatis/haskell-network-anonymous-i2p/blob/master/src/Network/Anonymous/I2P/Protocol.hs#L103 types pls
- https://github.com/solatis/haskell-network-anonymous-i2p/blob/master/src/Network/Anonymous/I2P/Protocol.hs#L132-L134 Better
- https://github.com/solatis/haskell-network-anonymous-i2p/blob/master/src/Network/Anonymous/I2P/Protocol.hs#L320 Another bare ByteString
- https://github.com/solatis/haskell-network-anonymous-i2p/tree/master/src/Network/Anonymous/I2P/Types Every type synonym -> data/newtype
HTH.