Sung Po-Han

Results 30 comments of Sung Po-Han

Hi @yhirose I am not sure how many of them will be, possibly the number being proportional to users located in China. I can add a toggle for this feature....

@yhirose I agree with you on enabling the feature by default. I also update CMake which enables the feature `HTTPLIB_USE_WINDOWS_AUTOMATIC_ROOT_CERTIFICATES_UPDATE` by default, and if disabled, define `CPPHTTPLIB_DISABLE_WINDOWS_AUTOMATIC_ROOT_CERTIFICATES_UPDATE`.

Sure, it looks like https://github.com/yhirose/cpp-httplib/pull/2169 saves openssl errors which I didn't notice. I'll try to fix it.

@yhirose I found that it is hard to map errors between Win32 API and OpenSSL. What do you recommend? Is it proper to mask those checks when Schannel is used?

@yhirose These errors are due to https://github.com/yhirose/cpp-httplib/pull/2169 adding `ssl_error` and `ssl_openssl_error` member functions to `class Result` for retrieving OpenSSL errors, and some tests being extended for these errors. As those...

> @solarispika it looks that the Windows code returns only `SSLServerVerification` and `SSLServerHostnameVerification` which are kind of general errors. However, it seems like some of wincrypt APIs can tell us...

Hi @heaths I have tested with latest version of vswhere. ![image](https://github.com/microsoft/vswhere/assets/4366282/c6beac0a-f1fc-4ddf-9004-7c27fb77804d) I'm not using prereleases or buildtools.

I ran the powershell but problem still exists. Here's the problem trace: [Logfile.zip](https://github.com/microsoft/vswhere/files/14785867/Logfile.zip)

Thank you for the information, I managed to recover the permission of the mentioned folder. The original output of the command is ```powershell  pika1  icacls "${env:ProgramData}\Microsoft\VisualStudio\Packages\_Instances" C:\ProgramData\Microsoft\VisualStudio\Packages\_Instances BUILTIN\Administrators:(F)...

Hi @yhirose, Before submitting a PR, I’d like to share some field experience regarding enabling Windows Automatic Root Certificates Update by default. After implementing this feature in our product using...