solanum icon indicating copy to clipboard operation
solanum copied to clipboard

flood_exempt connections should be able to do PM flood without voice-in-shared-channel

Open jesopo opened this issue 4 years ago • 3 comments

jesopo avatar Jun 03 '21 02:06 jesopo

diff --git a/modules/core/m_message.c b/modules/core/m_message.c
index 8825bbba..8e0cbbbe 100644
--- a/modules/core/m_message.c
+++ b/modules/core/m_message.c
@@ -785,6 +785,7 @@ msg_client(enum message_type msgtype,

                /* auto cprivmsg/cnotice */
                do_floodcount = !IsOperGeneral(source_p) &&
+                       !IsExemptFlood(source_p) &&
                        !find_allowing_channel(source_p, target_p);

                /* target change stuff, dont limit ctcp replies as that

RealKindOne avatar Jul 21 '25 03:07 RealKindOne

This feels to me like an arbitrary change that damages the architectural integrity. For example, why does the same not apply to sending to channels unvoiced?

jillest avatar Jul 27 '25 11:07 jillest

Because private messages use the msg_client section of code in the m_messages.c file.

Channel messages uses the msg_channel section of code in the m_messages.c file.

If you wanted it to apply to unvoiced you could just change this line of code in the msg_channel section of code.

-               if(result == CAN_SEND_OPV ||
+               if(result == CAN_SEND_OPV || IsOperGeneral(source_p) ||

RealKindOne avatar Jul 28 '25 00:07 RealKindOne