solana
solana copied to clipboard
[clap-v3-utils] Remove deprecated functions
Problem
Solana clap-v3-utils still uses deprecated functions from clap-v2.
Summary of Changes
- Replaced a number of deprecated functions like
possible_values
,value_of
, andmultiple_occurrences
with the updated functions from clap-v3. - Deprecated some existing parser functions that can be replaced by existing
clap-v3
functions - Deprecated some panicking functions like
keypair_of
,keypairs_of
, etc. in favor of theirtry_
variants
Clap-v3 has a feature deprecated
that, when included, gives warnings on deprecated functions. With this PR, all the deprecated functions should either be removed or explicitly allowed (on deprecated functions). However, if I include the deprecated
feature, it seems to turn this feature on in the rest of the repo on CI checks, so I left it out for now.
Fixes #
Codecov Report
Attention: Patch coverage is 57.95455%
with 37 lines
in your changes are missing coverage. Please review.
Project coverage is 81.8%. Comparing base (
7399178
) to head (838fd65
). Report is 11 commits behind head on master.
Additional details and impacted files
@@ Coverage Diff @@
## master #34989 +/- ##
========================================
Coverage 81.7% 81.8%
========================================
Files 836 836
Lines 224834 225069 +235
========================================
+ Hits 183847 184136 +289
+ Misses 40987 40933 -54
@CriesofCarrots @t-nelson, it would be great to get this PR merged before the migration 🙏 . Can you take one last look at the PR to check if the changes look sound?
This repository is no longer in use. Please re-open this pull request in the agave repo: https://github.com/anza-xyz/agave