solana icon indicating copy to clipboard operation
solana copied to clipboard

Feature Gate: Removing unwanted rounding in fee calculation

Open tao-stones opened this issue 5 months ago • 0 comments

SIMD

none

Description

A carry-over: transaction fee is converted to f64, then round() then convert back to u64. This is unnecessary, and rounding large f64 isn't accurate since f64 has precision of 53 binary digits (eg 2^53).

The conversion and rounding should be removed, but since it'd result different transaction fee is value is large enough, this change needs feature gate.

Feature ID

BtVN7YjDzNE6Dk7kTT7YTDgMNUZTNgiSJgsdzAeTg2jF

Activation Method

Single Core Contributor

Deployment Considerations

none

Minimum Beta Version

2.0.0

Minimum Stable Version

No response

Testnet Activation Epoch

No response

Devnet Activation Epoch

No response

Mainnet-Beta Activation Epoch

No response

tao-stones avatar Jan 27 '24 00:01 tao-stones