solana icon indicating copy to clipboard operation
solana copied to clipboard

[TieredStorage] writing hot account blocks and index blocks

Open yhchiang-sol opened this issue 1 year ago • 5 comments

Problem

The implementation of write_accounts() for HotAccountStorage is missing. It consists of the writing of account blocks, index block, and owners block.

Summary of Changes

This PR completes part of the HotStorageWriter::write_accounts(). Specifically, it finishes the writing of account blocks and index block.

Test Plan

A new unit-test is added to verify the correctness of the work-in-progress HotStorageWriter::write_accounts().

yhchiang-sol avatar Jan 18 '24 10:01 yhchiang-sol

⚠️ The sha of the head commit of this PR conflicts with #34792. Mergify cannot evaluate rules on this PR. ⚠️

mergify[bot] avatar Jan 18 '24 10:01 mergify[bot]

Rebase and remove the dependency.

yhchiang-sol avatar Jan 18 '24 19:01 yhchiang-sol

Closing https://github.com/solana-labs/solana/pull/34792 to see if this avoids the conflict.

The sha of the head commit of this PR conflicts with https://github.com/solana-labs/solana/pull/34792. Mergify cannot evaluate rules on this PR.

yhchiang-sol avatar Jan 18 '24 19:01 yhchiang-sol

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (b9947bd) 81.6% compared to head (465335a) 81.6%. Report is 10 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff            @@
##           master   #34828    +/-   ##
========================================
  Coverage    81.6%    81.6%            
========================================
  Files         827      827            
  Lines      224073   224183   +110     
========================================
+ Hits       183005   183152   +147     
+ Misses      41068    41031    -37     

codecov[bot] avatar Jan 18 '24 21:01 codecov[bot]

Rebasing to address conflict.

yhchiang-sol avatar Jan 19 '24 16:01 yhchiang-sol

Look like I might need to rebase. Let me know if the PR looks good. Then I will do a rebase.


+ cargo audit --ignore RUSTSEC-2020-0071 --ignore RUSTSEC-2023-0001 --ignore RUSTSEC-2022-0093
--
  | Fetching advisory database from `https://github.com/RustSec/advisory-db.git`
  | Loaded 592 security advisories (from /usr/local/cargo/advisory-db)
  | Updating crates.io index
  | Scanning Cargo.lock for vulnerabilities (799 crate dependencies)
  | Crate:     shlex
  | Version:   1.1.0
  | Title:     Multiple issues involving quote API
  | Date:      2024-01-21
  | ID:        RUSTSEC-2024-0006
  | URL:       https://rustsec.org/advisories/RUSTSEC-2024-0006
  | Solution:  Upgrade to >=1.3.0
  | Dependency tree:
  | shlex 1.1.0


yhchiang-sol avatar Jan 23 '24 11:01 yhchiang-sol

Look like I might need to rebase

Yep, this was fixed yesterday. Here's more info: https://discord.com/channels/428295358100013066/439194979856809985/1199044526677958767

brooksprumo avatar Jan 23 '24 14:01 brooksprumo

Let me do the rebase as the above should be the only open comment.

yhchiang-sol avatar Jan 24 '24 05:01 yhchiang-sol